Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update web library and package support #2820

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Update web library and package support #2820

merged 3 commits into from
Feb 13, 2024

Conversation

parlough
Copy link
Member

@parlough parlough commented Feb 9, 2024 •
edited
Loading

  • Resolve my earlier TODOs by deprecating dart:html and dart:js_util, joining dart:js.
  • Deprecate package:js
  • Add package:web to list of explicitly supported packages
  • Updates dependencies

Fixes #2819

@parlough
Copy link
Member Author

@johnpryan Any concerns with landing these changes?

It still allows usage of dart:html and dart:js_util for now, but does utilize functionality I added before to provide an info and links to the next-gen docs we're working on.

johnpryan
johnpryan approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@johnpryan johnpryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I can fix the conflicts

@parlough parlough merged commit 40311ba into main Feb 13, 2024
6 checks passed
@parlough parlough deleted the feat/web-package-updates branch February 13, 2024 20:14
@devoncarew devoncarew mentioned this pull request Feb 13, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnpryan johnpryan johnpryan approved these changes

@devoncarew devoncarew Awaiting requested review from devoncarew

Assignees

@johnpryan johnpryan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support package:web in dartpad
2 participants
@parlough @johnpryan