Cut 2.3.8 branch which parses at language version 3.6. #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 2.3.7 release of the formatter incorrectly defaults to parsing code at language version 3.3. That version doesn't support digit separators. The Dart 3.6.0 SDK release supports digit separators but includes dart_style 2.3.7, which can't format them. This PR creates a new 2.3.8 patch version that parses at the correct language version. Once this lands, I'll cherrypick it into the SDK and it will go out in the next stable patch release.
natebosch
approved these changes
Jan 23, 2025
kallentu
approved these changes
Jan 23, 2025
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jan 28, 2025
The 2.3.7 version of dart_style that shipped in Dart SDK 3.6.0 incorrectly parses Dart code at language version 3.3 instead of 3.6. That means it doesn't handle number literals with digit separators. In other words, `dart format` fails on any code that contains digit separators. This bumps the DEP to 2.3.8, which is a single-commit patch version from 2.3.7 that fixes the parser language version number. There are no other dart_style changes in 2.3.8. Bug: #59815 Change-Id: If2546edcd11bd424019d76b87c7c08695add331a Cherry-pick: dart-lang/dart_style#1636 Cherry-pick-request: #59998 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406204 Auto-Submit: Bob Nystrom <[email protected]> Commit-Queue: Alexander Thomas <[email protected]> Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2.3.7 release of the formatter incorrectly defaults to parsing code at language version 3.3. That version doesn't support digit separators. The Dart 3.6.0 SDK release supports digit separators but includes dart_style 2.3.7, which can't format them.
This PR creates a new 2.3.8 patch version that parses at the correct language version. Once this lands, I'll cherrypick it into the SDK and it will go out in the next stable patch release.
cc @athomas, @leafpetersen, @itsjustkevin, @mit-mit