-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch dart:js and some dart:js_util usages to use static interop #3299
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8c59543
Switch dart:js and dart:js_util usages to use static interop
parlough 9fde820
Merge branch 'master' into feature/js-static-interop
parlough 026aac3
Specify name as Response
parlough a045a9c
Merge branch 'master' into feature/js-static-interop
parlough 26b331a
Switch import to dart:js_util and add copyright headers
parlough 7f8ff7e
Merge branch 'master' into feature/js-static-interop
parlough File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import 'package:js/js.dart'; | ||
|
||
void init() { | ||
highlight?.highlightAll(); | ||
} | ||
|
||
@JS() | ||
@staticInterop | ||
class HighlightJs {} | ||
|
||
extension HighlightJsExtension on HighlightJs { | ||
external void highlightAll(); | ||
} | ||
|
||
@JS('hljs') | ||
external HighlightJs? get highlight; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
C6415C6028582DE4EC42B10F54BE3554 | ||
6B77B82B853707609123EE6D143030E9 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import 'package:js/js.dart'; | ||
import 'package:js/js_util.dart' as js_util; | ||
|
||
@JS('Response') | ||
@staticInterop | ||
class FetchResponse {} | ||
|
||
extension FetchResponseExtension on FetchResponse { | ||
external int get status; | ||
|
||
@JS('text') | ||
external Promise _text(); | ||
Future<String> get text => js_util.promiseToFuture(_text()); | ||
} | ||
|
||
@JS() | ||
@staticInterop | ||
class Promise {} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: This is fine and suggested to keep, but is unneeded, since
FetchResponse
has no constructor or static methods, which would be the only time we use this.