Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch dart:js and some dart:js_util usages to use static interop #3299

Merged
merged 6 commits into from
Jan 24, 2023
Merged

Switch dart:js and some dart:js_util usages to use static interop #3299

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8c59543
Switch dart:js and dart:js_util usages to use static interop
parlough Jan 14, 2023
9fde820
Merge branch 'master' into feature/js-static-interop
parlough Jan 15, 2023
026aac3
Specify name as Response
parlough Jan 15, 2023
a045a9c
Merge branch 'master' into feature/js-static-interop
parlough Jan 19, 2023
26b331a
Switch import to dart:js_util and add copyright headers
parlough Jan 23, 2023
7f8ff7e
Merge branch 'master' into feature/js-static-interop
parlough Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/sig.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2D8E7D7722AE5937479C00C043788871
6B77B82B853707609123EE6D143030E9
2 changes: 1 addition & 1 deletion web/web_interop.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import 'package:js/js.dart';
import 'package:js/js_util.dart' as js_util;

@JS()
@JS('Response')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: This is fine and suggested to keep, but is unneeded, since FetchResponse has no constructor or static methods, which would be the only time we use this.

@staticInterop
class FetchResponse {}

Expand Down