Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to create_api_docs.dart #3482

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Aug 28, 2023

Fixes #3481

@srawlins
Copy link
Member Author

CC @gspencergoog I'm having trouble migrating to create_api_docs.dart. I tried following the updates made to docs.sh in flutter/flutter@ced3e76, but I'm still getting:

pub:stdout: Resolving dependencies...
pub:stderr: Because Flutter depends on flutter_test from sdk which doesn't exist (the Flutter SDK is not available), version solving failed.
pub:stderr:
pub:stderr: Flutter users should run `flutter pub get` instead of `dart pub get`.

This is being printed by the runPubProcess command at line 450 in create_api_docs.dart. Any ideas?

@gspencergoog
Copy link
Collaborator

Looking at this. I think I may have switched to running dart pub get in some places instead of flutter pub get.

tool/task.dart Outdated Show resolved Hide resolved
@gspencergoog
Copy link
Collaborator

So, can you try out the changes in flutter/flutter#133493 ? I modified it to call flutter pub instead of dart pub, so the Flutter SDK should be available then.

@srawlins
Copy link
Member Author

Thanks a million, Greg! I think I can test locally against your PR (maybe?) but I'll wait till it lands to land this change.

@gspencergoog
Copy link
Collaborator

Okay, cool. Would you be willing to review that change, or should I find someone else?

@srawlins
Copy link
Member Author

Looks good Greg!

@srawlins srawlins requested a review from scheglov August 29, 2023 17:25
@srawlins srawlins merged commit 649bb8d into dart-lang:main Aug 29, 2023
9 checks passed
@srawlins srawlins deleted the fix-flutter branch August 29, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flutter changed their dartdoc.dart tool
3 participants