Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove abstract RendererFactory and template, category, and attribute renderers. #3612

Merged
merged 4 commits into from
Dec 27, 2023

Conversation

kallentu
Copy link
Member

Clean up I did a while ago, but I'll cut them into chunks so they're easier to review.

  • Removed template, category, and attribute renderers.
  • Inlined the renderer work wherever they were used.
  • Remove the abstract renderer factory to just use the HTML one.
  • Added a comment for future clean up.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@kallentu kallentu requested a review from srawlins December 23, 2023 00:13
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@kallentu kallentu merged commit c7473e4 into main Dec 27, 2023
11 checks passed
@kallentu kallentu deleted the remove-rendere branch December 27, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants