Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assertion that is no longer valid. #3913

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

srawlins
Copy link
Member

I actually can't imagine how it was ever valid. The InheritingContainer.inheritanceChain implementations can always result in a list that contains two instances of Object.

Also make inheritance private, and improve some related tests.

  • Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

I actually can't imagine how it was ever valid. The
`InheritingContainer.inheritanceChain` implementations can always result in a
list that contains two instances of Object.

Also make `inheritance` private, and improve some related tests.
@srawlins
Copy link
Member Author

Ready for review, @dart-lang/analyzer-team

@srawlins srawlins merged commit 73344a2 into dart-lang:main Oct 23, 2024
7 checks passed
@srawlins srawlins deleted the fix-inheritable-object branch October 23, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants