Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the check for the expected number of categorized libraries in Dart SDK #3962

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Jan 9, 2025

Recently many libraries were deprecated, and the HTML changed sufficiently to break our sanity check that we generate anything when we generate the SDK docs.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew
Copy link
Member

I think these changes are expected. Is that right @devoncarew ? I can get a screenshot of the new categorization on the sidebar.

Did something land here? I thought https://dart-review.googlesource.com/c/sdk/+/403387 was still in progress.

@srawlins
Copy link
Member Author

srawlins commented Jan 9, 2025

Ah the count difference is just from the libraries being deprecated, and so the HTML doesn't match what that test expects. The newly deprecated libraries are still visible, but srtuck through.

@srawlins srawlins changed the title Reduce the expected number of categorized libraries in Dart SDK Fix the check for the expected number of categorized libraries in Dart SDK Jan 9, 2025
@srawlins
Copy link
Member Author

srawlins commented Jan 9, 2025

CC @dart-lang/analyzer-team

@srawlins srawlins merged commit e129586 into dart-lang:main Jan 10, 2025
9 checks passed
@srawlins srawlins deleted the less-docs branch January 10, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants