Try a fix for the health check socket issues (#164)

dart-lang · Sep 12, 2023 · e96fbdb · e96fbdb
1 parent 4cc5005
commit e96fbdb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/pkgs/firehose/lib/src/health/coverage.dart b/pkgs/firehose/lib/src/health/coverage.dart
@@ -17,8 +17,8 @@ class Coverage {
 
   Coverage(this.coverageWeb);
 
-  Future<CoverageResult> compareCoverages() async {
-    var files = await Github().listFilesForPR();
+  Future<CoverageResult> compareCoverages(Github github) async {
+    var files = await github.listFilesForPR();
     var basePath = '../base_repo/';
 
     return compareCoveragesFor(files, basePath);

diff --git a/pkgs/firehose/lib/src/health/health.dart b/pkgs/firehose/lib/src/health/health.dart
@@ -93,7 +93,7 @@ Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automati
   }
 
   Future<HealthCheckResult> licenseCheck(Github github) async {
-    var files = await Github().listFilesForPR();
+    var files = await github.listFilesForPR();
     var allFilePaths = await getFilesWithoutLicenses(Directory.current);
 
     var groupedPaths = allFilePaths
@@ -159,7 +159,7 @@ Changes to files need to be [accounted for](https://github.com/dart-lang/ecosyst
     Github github,
     bool coverageWeb,
   ) async {
-    var coverage = await Coverage(coverageWeb).compareCoverages();
+    var coverage = await Coverage(coverageWeb).compareCoverages(github);
 
     var markdownResult = '''
 | File | Coverage |