Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make double disposal and double creation visible. #118

Open
polina-c opened this issue Aug 7, 2023 · 1 comment
Open

Make double disposal and double creation visible. #118

polina-c opened this issue Aug 7, 2023 · 1 comment
Labels
P2 A bug or feature request we're likely to work on Size:M weeks

Comments

@polina-c
Copy link
Contributor

polina-c commented Aug 7, 2023

Right now leak_tracker ignores cases of double disposal or double start of tracking.
It is possible for leak tracker to expose the issue as one more type of memory issue, in addition to notDisposed or not GCed types of memory leaks.

This issue is created to collect community feedback.

Please, upvote and add comment about your usage story, if you are interested.

@polina-c polina-c changed the title How leak_tracker should handle double disposal and double creation? Make double disposal and double creation visible. Aug 14, 2023
@polina-c polina-c added P2 A bug or feature request we're likely to work on Size:S days Size:M weeks and removed Size:S days labels Aug 14, 2023
@polina-c
Copy link
Contributor Author

polina-c commented Apr 1, 2024

Not all users of leak_tracker want leak_tracker to fail on double dispatch of creation or disposal.
So, there should be an option to configure leak_tracker to fail or not to fail in such cases.

But there is a challenge: some dependencies may be doing double disposal that will cause failure of consumers that want to fail on double disposal.

May be it is better to implement in leak tracker instrumentation macro: flutter/flutter#137435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on Size:M weeks
Projects
None yet
Development

No branches or pull requests

1 participant