Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop failing if object is disposed twice. #117

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented Aug 7, 2023

The failures affect running application.

This fix will unblock the PR: flutter/flutter#131998

@kenzieschmoll
Copy link

Instead of allowing objects to be disposed twice, shouldn't we prevent them from being disposed twice?

@polina-c
Copy link
Contributor Author

polina-c commented Aug 7, 2023

Instead of allowing objects to be disposed twice, shouldn't we prevent them from being disposed twice?

It may be good idea, but for future scope of leak_tracker. Right now it is not leak tracker responsibility.
But, if we decide to add it to scope, failure is not right way to handle double disposal, because leak_tracker should not change the application or test behaviour.

So, if we want to handle it, it requires additional discussion and design.
Right now i want to turn off failures to stop blocking big PR in flutter that may get merge conflicts.

Created TODO and issue for discussion: #118

Copy link
Member

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@polina-c polina-c merged commit 02d0b2f into dart-lang:main Aug 7, 2023
2 checks passed
@polina-c polina-c deleted the double-disposal branch August 7, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants