Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Merge workflows #13

Merged
merged 4 commits into from
Apr 20, 2023
Merged

[CI] Merge workflows #13

merged 4 commits into from
Apr 20, 2023

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Apr 20, 2023

@coveralls
Copy link

coveralls commented Apr 20, 2023

Coverage Status

coverage: 99.903% (-0.1%) from 100.0%
when pulling 7a97684 on merge-workflows
into 9350cb7 on main.

@dcharkes dcharkes enabled auto-merge (squash) April 20, 2023 14:04
Copy link
Member

@HosseinYousefi HosseinYousefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thanks @dcharkes!

@@ -47,8 +46,10 @@ jobs:
if: ${{ matrix.sdk == 'stable' }}

- run: dart pub get

- run: dart pub get
working-directory: pkgs/native_assets_cli/example/native_add/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? I thought pub get recursively gets all the dependencies.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flutter pub get does, dart pub get doesn't.

@dcharkes dcharkes merged commit 449af2d into main Apr 20, 2023
@dcharkes dcharkes deleted the merge-workflows branch April 20, 2023 14:07
HosseinYousefi pushed a commit that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants