Use bold to distinguish package names in solve-traces #3741
+43
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonasfj, @szakarias WDYT? |
|
Closing this as it is stale. Feel free to reopen in case you still want to land it! |
|
I still have some hope for this. Thanks for reminding me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at fixing: #3363 by using ansi colors to highlight package names in the solve-trace. This should make it a bit easier to read - especially if packages have keyword-like names.
An alternative would be to prefix package names with
package:...This has an issue with how we cannot nest colorization of ansi colors...
Draft to get feedback for the idea if it is worth handling implementing ansi-colorization.