Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No errors from credentials file #4004

Merged
merged 2 commits into from
Aug 31, 2023
Merged

No errors from credentials file #4004

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85b7e78
Don't display details about credentials parse error
sigurdm Aug 31, 2023
49dff08
Explanatory comment
sigurdm Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/src/oauth2.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,9 @@ Credentials? loadCredentials() {

return credentials;
} catch (e) {
log.error('Warning: could not load the saved OAuth2 credentials: $e\n'
// Don't print the error message itself here. I might be leaking data about
// credentials.
log.error('Warning: could not load the saved OAuth2 credentials.\n'
'Obtaining new credentials...');
return null; // null means re-authorize.
}
Expand Down