Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and auto-include cheatsheet code samples #2295

Closed
jddeep opened this issue Mar 3, 2020 · 4 comments · Fixed by #2296, #2298 or #3481
Closed

Add and auto-include cheatsheet code samples #2295

jddeep opened this issue Mar 3, 2020 · 4 comments · Fixed by #2296, #2298 or #3481
Assignees
@jddeep
Labels
e1-hours Can complete in < 8 hours of normal, not dedicated, work fix.examples Adds or changes example p2-medium Necessary but not urgent concern. Resolve when possible.

Comments

@jddeep
Copy link
Contributor

jddeep commented Mar 3, 2020

We need to add the cheatsheet code samples in the repo so that we can link the code-excerpts in the source file.

Context: #1803

cc: @kwalrath
@jddeep jddeep mentioned this issue Mar 3, 2020
Merged
@kwalrath kwalrath changed the title Adding the cheatsheet code samples Add and auto-include cheatsheet code samples Mar 4, 2020
kwalrath added a commit that referenced this issue Mar 4, 2020
@kwalrath
[site-www] Adding the code files for the codelabs cheatsheet accordin…
0eed303 
…g to src (#2296)

Contributes to #2295 

Co-authored-by: Kathy Walrath <[email protected]>
@kwalrath kwalrath reopened this Mar 4, 2020
@kwalrath
Copy link
Contributor

kwalrath commented Mar 4, 2020

#2296 fixes the issue of having tests for the code, but now we need to auto-include the code in the cheatsheet codelab.

@jddeep
Copy link
Contributor Author

jddeep commented Mar 5, 2020

@kwalrath I will make a PR for including the code-excerpts in the cheatsheet src .md file. should we close this and direct that PR to #1803 ? Let me know while I make the PR :)

@jddeep jddeep mentioned this issue Mar 5, 2020
Merged
@kwalrath
Copy link
Contributor

kwalrath commented Mar 5, 2020

What you did (saying that your new PR fixes this issue) is the right thing. I'll take a look at your PR today. Thank you!

@kwalrath kwalrath added e1-hours Can complete in < 8 hours of normal, not dedicated, work fix.examples Adds or changes example p1-high Major but not urgent concern: Resolve in months. Update each month. labels Mar 5, 2020
@kwalrath
Copy link
Contributor

I think we still have some code that isn't analyzed, so I'm going to reopen this until we ascertain that there's no more left to do.

@kwalrath kwalrath reopened this Mar 10, 2020
@kwalrath kwalrath added p2-medium Necessary but not urgent concern. Resolve when possible. and removed p1-high Major but not urgent concern: Resolve in months. Update each month. labels Feb 23, 2021
@parlough parlough mentioned this issue Aug 8, 2021
Merged
parlough added a commit to parlough/site-www that referenced this issue Aug 10, 2021
@parlough
Analyze and test more cheatsheet snippets
142e7c4 
Fixes dart-lang#2295
@parlough parlough mentioned this issue Aug 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jddeep jddeep

Labels
e1-hours Can complete in < 8 hours of normal, not dedicated, work fix.examples Adds or changes example p2-medium Necessary but not urgent concern. Resolve when possible.
Projects
None yet
Milestone
No milestone
2 participants
@kwalrath @jddeep