Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyze and test more cheatsheet snippets #3481

Merged
merged 4 commits into from
Aug 11, 2021
Merged

Analyze and test more cheatsheet snippets #3481

merged 4 commits into from
Aug 11, 2021

Conversation

parlough
Copy link
Member

Fixes #2295

@google-cla google-cla bot added the cla: yes Contributor has signed the Contributor License Agreement label Aug 10, 2021
@parlough parlough marked this pull request as ready for review August 10, 2021 20:52
@parlough parlough marked this pull request as draft August 10, 2021 20:53
@parlough parlough force-pushed the excerpts/analyze-and-test-final-cheatsheet-snippets branch from 142e7c4 to d048679 Compare August 10, 2021 23:10
@parlough parlough marked this pull request as ready for review August 10, 2021 23:31
kwalrath
kwalrath reviewed Aug 11, 2021
View reviewed changes
Copy link
Contributor

@kwalrath kwalrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We should also get an engineer to review the code.

@domesticmouse? @johnpryan?

@johnpryan johnpryan mentioned this pull request Aug 11, 2021
Closed
@parlough parlough merged commit b0676c6 into dart-lang:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwalrath kwalrath kwalrath left review comments

@johnpryan johnpryan johnpryan approved these changes

Assignees
No one assigned
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add and auto-include cheatsheet code samples
3 participants
@parlough @johnpryan @kwalrath