Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyze/test analysis-options page code excerpts #1912

Merged
merged 5 commits into from
Sep 19, 2019
Merged

Analyze/test analysis-options page code excerpts #1912

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c3b1bfe
Analysis options page: ensure code excerpts are analyzed/tested
chalin Sep 16, 2019
7c6008a
Replace images of code with tooltip by code excerpts
chalin Sep 16, 2019
47fdec7
Edits inspired by Kathy's comments
chalin Sep 18, 2019
35c759c
Add IDE-like analyzer-error highlighting to implicit-casts example
chalin Sep 18, 2019
01cd4f2
Drop linenums from implicit-casts example
chalin Sep 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/_guides/language/analysis-options.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,10 @@ You can use the flags together or separately; both default to `true`.
includes an implicit downcast that would be caught by this flag:

{:.fails-sa}
<?code-excerpt "analysis/lib/assignment.dart (implicit-downcast)"?>
{% prettify dart %}
<?code-excerpt "analysis/lib/assignment.dart (implicit-downcast)" replace="/(s = )(o)/$1[!$2!]/g"?>
{% prettify dart class="linenums:10 analyzer" %}
chalin marked this conversation as resolved.
Show resolved Hide resolved
Object o = ...
String s = o; // Implicit downcast
String s = [!o!]; // Implicit downcast
String s2 = s.substring(1);
{% endprettify %}

Expand Down