-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the 2.19 entry to the "What's new" page #4542
Conversation
Might have one more "what's new" entry if #4528 is ready in time |
Thanks for working on this! I’ll take a look early tomorrow. We can hold off on this one until the blog posts are released. I switched to draft to better signify that. |
So, the release blog post doesn't actually go out until the 25th. Idk if you want to wait that long. I could just remove that link until tomorrow. I did just replace the author part of the draft urls (i.e. "mit-mit"/"mbelanger") with "dartlang", which is what they'll be once published, so at least they're not broken links |
Hmm, maybe "What's new on dart.dev" is not the best new page title, since the first sentence says "This page describes what’s new on the Dart website and blog"... Thoughts? |
About the language evolution page:
|
I think it makes sense to keep "What's new" released on the same day as those, especially with all the blog links, but am happy to get in it today if you'd like. We've had mismatch before during 2.13 and that's what we did since there's no need to rush this page update. Consider separating the language evolution changes to a new PR targeting the
I didn't consider that, thanks for pointing it out. I guess it's fine to stick to the old title since on the website we only link to it with context. I do get this as the first search result for "What's new in Dart" so it is a tad confusing, but we do link to the blog posts and changelog so it's probably okay.
Yep! We should skip those pieces :) - We use the page for primarily pure language changes, outside of a few minor exceptions before. |
20da5fe
to
26b0a8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really love both these additions! You were so thorough :D
Co-authored-by: Parker Lougheed <[email protected]>
Oh I definitely still think the name should change, more so now that you've pointed that out. I just meant "...on dart.dev" doesn't make sense, so maybe "What's new in Dart documentation" or "What's new in Dart docs"? Just a question of sound/feel (better ideas welcome 😅 ) |
Co-authored-by: Parker Lougheed <[email protected]>
Visit the preview URL for this PR (updated for commit 4bb4a32): https://dart-dev--pr4542-whats-new-language-e-o6qj0j4b.web.app (expires Wed, 01 Feb 2023 17:37:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, a very impressive list! Especially given that this was all after Kathy resigned. lgtm
Thanks for the review @sfshaza2. Marya did a great job with this list and release :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some final comments/suggestions then looks good to me. Thanks @MaryaBelanger!
Co-authored-by: Parker Lougheed <[email protected]>
Adds the 2.19 entry to the "What's new" page.
Fixes #4404