Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DartPad tutorial best practices #5383

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

parlough
Copy link
Member

Support for tests/solutions/hints/etc (at least in their current form) is going away soon in embedded DartPads, so I don't think we should be surfacing guidelines on how to best use them.

This PR removes that page and redirects to an underlying paper which publishes some of the same findings.

Contributes to #5382

@parlough parlough added the review.copy Awaiting Copy Review label Nov 30, 2023
Copy link

github-actions bot commented Dec 1, 2023

Visit the preview URL for this PR (updated for commit 049d0de):

https://dart-dev--pr5383-misc-remove-dartpad-qfhvp8b8.web.app

(expires Mon, 11 Dec 2023 22:14:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3

@MaryaBelanger MaryaBelanger self-assigned this Dec 1, 2023
Copy link
Contributor

@atsansone atsansone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@atsansone atsansone added st.RFM Ready to merge or land and removed review.copy Awaiting Copy Review labels Dec 7, 2023
@parlough parlough removed the st.RFM Ready to merge or land label Dec 8, 2023
@parlough parlough removed the request for review from MaryaBelanger December 8, 2023 06:30
@parlough parlough merged commit b6cb885 into main Dec 8, 2023
9 checks passed
@parlough parlough deleted the misc/remove-dartpad-tutorial-guidelines branch December 8, 2023 06:30
atsansone pushed a commit to atsansone/site-www that referenced this pull request Jan 26, 2024
Support for tests/solutions/hints/etc (at least in their current form)
is going away soon in embedded DartPads, so I don't think we should be
surfacing guidelines on how to best use them.

This PR removes that page and redirects to an underlying paper which
publishes some of the same findings.

Contributes to dart-lang#5382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants