-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update front page content #5413
Conversation
Visit the preview URL for this PR (updated for commit 3357762): https://dart-dev--pr5413-mitfrontpage-gmrr5w2s.web.app (expires Tue, 26 Dec 2023 11:26:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this repositioning! I defer to @MaryaBelanger for a copy review though :)
Consider updating the .github
profile as well: https://github.com/dart-lang/.github/tree/main/profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mit-mit! Could you add a period (.
) to the end of each of the bullets in the three main sections ("Approachable", "Productive development", and "Fast on all platforms")?
I left comments on the sentences you edited, but really they should all end with periods, if that's not too much trouble to take care of now (and if it is just lmk and I'll take care of it in another pr!)
Co-authored-by: Parker Lougheed <[email protected]> Co-authored-by: Marya <[email protected]>
Certainly, done! |
Update front page text to better match current language positioning. --------- Co-authored-by: Parker Lougheed <[email protected]> Co-authored-by: Marya <[email protected]>
Update front page text to better match current language positioning.
Staged here: https://dart-dev--pr5413-mitfrontpage-gmrr5w2s.web.app/