Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update front page content #5413

Merged
merged 5 commits into from
Dec 19, 2023
Merged

Update front page content #5413

merged 5 commits into from
Dec 19, 2023

Conversation

mit-mit
Copy link
Member

@mit-mit mit-mit commented Dec 18, 2023

Update front page text to better match current language positioning.

Staged here: https://dart-dev--pr5413-mitfrontpage-gmrr5w2s.web.app/

@mit-mit mit-mit requested a review from mraleph December 18, 2023 12:57
Copy link

github-actions bot commented Dec 18, 2023

Visit the preview URL for this PR (updated for commit 3357762):

https://dart-dev--pr5413-mitfrontpage-gmrr5w2s.web.app

(expires Tue, 26 Dec 2023 11:26:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3

Copy link
Member

@mraleph mraleph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this repositioning! I defer to @MaryaBelanger for a copy review though :)

Consider updating the .github profile as well: https://github.com/dart-lang/.github/tree/main/profile

src/index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mit-mit! Could you add a period (.) to the end of each of the bullets in the three main sections ("Approachable", "Productive development", and "Fast on all platforms")?

I left comments on the sentences you edited, but really they should all end with periods, if that's not too much trouble to take care of now (and if it is just lmk and I'll take care of it in another pr!)

src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
@mit-mit
Copy link
Member Author

mit-mit commented Dec 19, 2023

Could you add a period

Certainly, done!

@mit-mit mit-mit merged commit d2001db into main Dec 19, 2023
9 checks passed
@mit-mit mit-mit deleted the mitfrontpage branch December 19, 2023 11:30
atsansone pushed a commit to atsansone/site-www that referenced this pull request Jan 26, 2024
Update front page text to better match current language positioning.

---------

Co-authored-by: Parker Lougheed <[email protected]>
Co-authored-by: Marya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants