Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove low-level HTML tutorials and add redirects #5415

Merged
merged 12 commits into from
Dec 21, 2023

Conversation

parlough
Copy link
Member

@parlough parlough commented Dec 18, 2023

These tutorials are heavily built around multi-file DartPad support which is going away and web programming will be changing greatly with package:web and static interop in the future. Due to the low views these pages get, this PR proposes removing them for now rather than restructuring them for their short remaining time to live. Reducing our maintenance costs and unblocking the DartPad work.

Contributes to #5382 and #4331

We can always revive these pages from Git history if needed or desired :)

Copy link

github-actions bot commented Dec 19, 2023

Visit the preview URL for this PR (updated for commit 54aa87f):

https://dart-dev--pr5415-feat-remove-low-leve-qvpgbl9u.web.app

(expires Wed, 27 Dec 2023 19:35:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3

@parlough parlough marked this pull request as ready for review December 19, 2023 03:56
@parlough parlough added the review.copy Awaiting Copy Review label Dec 19, 2023
@parlough parlough changed the title [WIP] Remove low-level HTML tutorials and add redirects Remove low-level HTML tutorials and add redirects Dec 19, 2023
Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, besides updating links, none of the remaining content has changed, right? Mostly wondering because of the get-started.md page moved out from under /tutorials -- I'm pretty sure there's no content changes on the "new" page but let me know if you did any writing and want a copy edit

@parlough
Copy link
Member Author

parlough commented Dec 19, 2023

@MaryaBelanger Sorry, I should have added more details to the PR description. There are some writing changes if you could take a quick look:

  • The moved Get started page
    • A few changes throughout and a new, small deploy section at the end. Might be worth skimming the changes and existing text since it will exist for a little while more at least.
  • The updated/reduced Web libraries page
    • Mostly removing a table that had a bunch of out of date packages in it. I think it doesn't make sense for us to maintain this arbitrary list.

@parlough parlough removed the review.copy Awaiting Copy Review label Dec 20, 2023
Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Parker! Couple of copy comments

src/web/get-started.md Outdated Show resolved Hide resolved
src/web/get-started.md Outdated Show resolved Hide resolved
src/web/get-started.md Show resolved Hide resolved
Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry forgot I already approved it 😅

@parlough parlough merged commit 57857f5 into main Dec 21, 2023
9 checks passed
@parlough parlough deleted the feat/remove-low-level-html-tutorials branch December 21, 2023 04:48
atsansone pushed a commit to atsansone/site-www that referenced this pull request Jan 26, 2024
These tutorials are heavily built around multi-file DartPad support
which is going away and web programming will be changing greatly with
`package:web` and static interop in the future. Due to the low views
these pages get, this PR proposes removing them for now rather than
restructuring them for their short remaining time to live. Reducing our
maintenance costs and unblocking the DartPad work.

Contributes to dart-lang#5382 and
dart-lang#4331

We can always revive these pages from Git history if needed or desired
:)

---------

Co-authored-by: Marya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants