Remove old staging workflow and organize remaining ones #5445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parlough
changed the title
|
Visit the preview URL for this PR (updated for commit f9fda1d): https://dart-dev--pr5445-misc-remove-duplicate-stage-wsnnby6m.web.app |
|
Once again, you are awesome @parlough. I'm literally just about to open a PR to move the deploy to Cloud Build. |
atsansone
pushed a commit
to atsansone/site-www
that referenced
this pull request
Jan 26, 2024
I imagine we'll update the deploy to use Cloud Build eventually as well, but I'd like to get some of this standardization in first to prevent duplicate work (and comments). This PR removes the old staging workflow and creates a new job to build the site and check the links. It separates the deploy job to a separate file as well, since it only runs on push and will likely be replaced soon :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I imagine we'll update the deploy to use Cloud Build eventually as well, but I'd like to get some of this standardization in first to prevent duplicate work (and comments).
This PR removes the old staging workflow and creates a new job to build the site and check the links.
It separates the deploy job to a separate file as well, since it only runs on push and will likely be replaced soon :)
Thanks for taking a look (and for the Cloud Build work) 💙 !