Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about security advisories #5480

Merged
merged 15 commits into from
Jan 24, 2024

Conversation

szakarias
Copy link
Contributor

No description provided.

src/tools/pub/security-advisories.md Outdated Show resolved Hide resolved
src/tools/pub/security-advisories.md Outdated Show resolved Hide resolved
szakarias and others added 2 commits January 23, 2024 13:43
@parlough parlough added the review.copy Awaiting Copy Review label Jan 23, 2024
@MaryaBelanger
Copy link
Contributor

/gcbrun

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Jan 23, 2024

Visit the preview URL for this PR (updated for commit 5d2363d):

https://dart-dev--pr5480-advisoriesdoc-53s6gdef.web.app

Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but some broken markdown so I left suggestions

src/tools/pub/security-advisories.md Outdated Show resolved Hide resolved
src/tools/pub/security-advisories.md Show resolved Hide resolved
src/tools/pub/security-advisories.md Outdated Show resolved Hide resolved
src/tools/pub/security-advisories.md Show resolved Hide resolved
src/tools/pub/security-advisories.md Outdated Show resolved Hide resolved
src/tools/pub/security-advisories.md Show resolved Hide resolved
src/tools/pub/security-advisories.md Outdated Show resolved Hide resolved
src/tools/pub/security-advisories.md Outdated Show resolved Hide resolved
Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MaryaBelanger MaryaBelanger merged commit 7b832ca into dart-lang:main Jan 24, 2024
8 checks passed
@parlough
Copy link
Member

Exciting stuff. Thanks all!

parlough added a commit that referenced this pull request Jan 24, 2024
Follow-up to #5480

Fixes #5458

A few things:

- Adjusts the placeholder redirect to point to the new page
- Add a cross-link from the pubspec reference page
- Fixes a few typos
- Use descriptive link text instead of "Here"
- Remove `/en` from the GitHub link, so it's more likely redirect to the
desired language of the user
- In the "Ignoring security advisories" section, if putting the pubspec
field `ignored_advisories` in code font, it's not really "a list of
`ignored_advisories`, but rather a list itself.
- Uses proper capitalization for "GitHub"
- Use "the Dart team" instead of "we" for the recommendation
- Some other minor wording adjustments _(please take a look :])_
atsansone pushed a commit to atsansone/site-www that referenced this pull request Jan 26, 2024
atsansone pushed a commit to atsansone/site-www that referenced this pull request Jan 26, 2024
Follow-up to dart-lang#5480

Fixes dart-lang#5458

A few things:

- Adjusts the placeholder redirect to point to the new page
- Add a cross-link from the pubspec reference page
- Fixes a few typos
- Use descriptive link text instead of "Here"
- Remove `/en` from the GitHub link, so it's more likely redirect to the
desired language of the user
- In the "Ignoring security advisories" section, if putting the pubspec
field `ignored_advisories` in code font, it's not really "a list of
`ignored_advisories`, but rather a list itself.
- Uses proper capitalization for "GitHub"
- Use "the Dart team" instead of "we" for the recommendation
- Some other minor wording adjustments _(please take a look :])_
atsansone pushed a commit to atsansone/site-www that referenced this pull request Feb 20, 2024
atsansone pushed a commit to atsansone/site-www that referenced this pull request Feb 20, 2024
Follow-up to dart-lang#5480

Fixes dart-lang#5458

A few things:

- Adjusts the placeholder redirect to point to the new page
- Add a cross-link from the pubspec reference page
- Fixes a few typos
- Use descriptive link text instead of "Here"
- Remove `/en` from the GitHub link, so it's more likely redirect to the
desired language of the user
- In the "Ignoring security advisories" section, if putting the pubspec
field `ignored_advisories` in code font, it's not really "a list of
`ignored_advisories`, but rather a list itself.
- Uses proper capitalization for "GitHub"
- Use "the Dart team" instead of "we" for the recommendation
- Some other minor wording adjustments _(please take a look :])_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review.copy Awaiting Copy Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants