Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section on external #5481

Merged
merged 8 commits into from
Jan 31, 2024
Merged

Add section on external #5481

merged 8 commits into from
Jan 31, 2024

Conversation

MaryaBelanger
Copy link
Contributor

Fixes #5478

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Jan 23, 2024

Visit the preview URL for this PR (updated for commit c75b7cb):

https://dart-dev--pr5481-lang-external-12evoqbf.web.app

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another one down (from the external keyword table links) 🥳!

Thanks for working on this Marya! Reads well to me.

I do have one question that is maybe me overthinking things. Let me know what you think :)

src/language/functions.md Show resolved Hide resolved
src/language/functions.md Outdated Show resolved Hide resolved
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me after one more consideration. Thanks for documenting this Marya!

Do consider waiting for Erik's review before landing, unless you need this landed for something else. We can always make changes as the various uses of the keyword start to be documented too :D

src/language/functions.md Outdated Show resolved Hide resolved
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/language/functions.md Outdated Show resolved Hide resolved
src/language/functions.md Outdated Show resolved Hide resolved
@MaryaBelanger MaryaBelanger merged commit 4a5f02a into main Jan 31, 2024
8 checks passed
atsansone pushed a commit to atsansone/site-www that referenced this pull request Feb 1, 2024
atsansone pushed a commit to atsansone/site-www that referenced this pull request Feb 9, 2024
atsansone pushed a commit to atsansone/site-www that referenced this pull request Feb 20, 2024
@kevmoo kevmoo deleted the lang/external branch August 20, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document external on the Functions page
4 participants