-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add section on external
#5481
Add section on external
#5481
Conversation
Visit the preview URL for this PR (updated for commit c75b7cb): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another one down (from the external keyword table links) 🥳!
Thanks for working on this Marya! Reads well to me.
I do have one question that is maybe me overthinking things. Let me know what you think :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me after one more consideration. Thanks for documenting this Marya!
Do consider waiting for Erik's review before landing, unless you need this landed for something else. We can always make changes as the various uses of the keyword start to be documented too :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes dart-lang#5478 --------- Co-authored-by: Erik Ernst <[email protected]>
Fixes dart-lang#5478 --------- Co-authored-by: Erik Ernst <[email protected]>
Fixes dart-lang#5478 --------- Co-authored-by: Erik Ernst <[email protected]>
Fixes #5478