Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference documentation for 'ignored_advisories' in the pubspec #5487

Merged
merged 5 commits into from
Jan 26, 2024

Conversation

szakarias
Copy link
Contributor

No description provided.

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Jan 25, 2024

Visit the preview URL for this PR (updated for commit 685495a):

https://dart-dev--pr5487-ignoredadvisoryrefdoc-wp0ibbtu.web.app

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for expanding on this @szakarias! I appreciate it =D

Looks good to me, but some small suggestions to consider:

src/tools/pub/pubspec.md Outdated Show resolved Hide resolved
src/tools/pub/pubspec.md Outdated Show resolved Hide resolved
szakarias and others added 2 commits January 26, 2024 09:56
Co-authored-by: Parker Lougheed <[email protected]>
Co-authored-by: Parker Lougheed <[email protected]>
@szakarias
Copy link
Contributor Author

Thanks @parlough for your suggestions!

@parlough parlough merged commit cf0d582 into dart-lang:main Jan 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants