Updated supported platform language #5497
Conversation
atsansone
changed the title
|
Visit the preview URL for this PR (updated for commit 771f43b): |
atsansone
force-pushed
the
fix-5496
branch
6 times, most recently
from
9054c06
to
8f5770f
Compare
|
High-level feedback: I really like the improvements to the verbiage here, but I do not like that we're pulling the listings of what the supported architectures are into the three Windows/Linux/mac OS tabs. That makes it really hard to get an overview of what the total set of platforms are. I suggest we move that down below the tabs again. Moving it to a tabular format is still a good idea (the old bullet lists were a bit unwieldy). We also seem to have lost the link to install the SDK from the SDK archives (which I believe is the 2nd most popular way of installing). |
atsansone
force-pushed
the
fix-5496
branch
3 times, most recently
from
f4ac23e
to
e6cb252
Compare
|
Updated. Direct link: https://dart-dev--pr5497-fix-5496-y29lg1dk.web.app/get-dart |
src/get-dart/index.md
Outdated
| |----------|---------|---------|---------|-----------|-----------|------------------------------------------| | ||
| | Windows | {{yes}} | {{yes}} | {{no}} | {{beta}} | {{no}} | 10 (32-bit, 64-bit), 11 | | ||
| | Linux | {{yes}} | {{yes}} | {{yes}} | {{yes}} | {{beta}} | [Debian stable][], [Ubuntu LTS][] | | ||
| | macOS | {{no}} | {{yes}} | {{no}} | {{yes}} | {{no}} | {{macversions}} | |
There was a problem hiding this comment.
macOS: arm & macOS: risc-v should be "n/a" (those versions of macOS don't exist)
There was a problem hiding this comment.
RISC-V is listed as not supported. ARM64 would have to be supported if it were to work on M1 & M2 Macs, right?
There was a problem hiding this comment.
DBC: did a quick look over this and I think this table covers all the platforms we support.
There was a problem hiding this comment.
Currently the page renders a big red X for macOS on x86, ARM32, and RISC-V. That is accurate for x86 -- a version of macOS for x86 exists, but we don't support it (it's very old). However it gives the wrong impression for macOS on ARM32 and risc-v as those versions of macOS do not exist.
There was a problem hiding this comment.
@mit-mit : Would it help to add a "deprecated" icon for the macOS x86 to distinguish it from not existing?
There was a problem hiding this comment.
I suggest a neutral (e.g. gray) "not applicable" icon.
|
I'm marking this approved now, but before merging, I'd like for @athomas to review the supported table: |
atsansone
force-pushed
the
fix-5496
branch
2 times, most recently
from
92d9cf7
to
7edcf35
Compare
atsansone
added
review.tech
|
Is there something we can do to make the cookiebar not be cut off on mobile because of the oversized system requirements table? I can reproduce it on desktop in devtools mobile emulation and on mobile chrome. The cookiebar is as wide as the table despite the viewport being smaller. Doesn't happen on the frontpage for instance. |
|
Probably, but it would be done in a different PR. Can we land this PR first and look at ways to resolve this new issue separately? |
Ok for me, it does seem to be a regression introduced in this PR. Can't see the issue on the current version. |
Fixes #5496
Fixes #4414
Fixes #5499