Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate iterables codelab away from multi-file #5542

Merged
merged 7 commits into from
Feb 14, 2024

Conversation

parlough
Copy link
Member

@parlough parlough commented Feb 14, 2024

  • Removes usage of multi-file DartPad support (tests, hints, solutions)
  • Introduces new separate Hint and Solution details-based dropdowns

Contributes to #5382

Staged: https://dart-dev--pr5542-fix-migrate-iterables-codelab-4glpkbdh.web.app/codelabs/iterables

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Feb 14, 2024

Visit the preview URL for this PR (updated for commit f4d59ac):

https://dart-dev--pr5542-fix-migrate-iterables-codelab-4glpkbdh.web.app

@parlough parlough force-pushed the fix/migrate-iterables-codelab branch from 74930c8 to 144bf02 Compare February 14, 2024 02:18
@parlough parlough marked this pull request as ready for review February 14, 2024 17:05
@parlough parlough changed the title [WIP] Migrate iterables codelab away from multi-file Migrate iterables codelab away from multi-file Feb 14, 2024
Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Aside question, what does the "Show tests" option (and the empty tab it opens) mean? Will that just not show up anymore after the new dartpad update?
image

@parlough
Copy link
Member Author

Yeah, that's just shown on all embeds with the old UI, so there's unfortunately no way to disable it. It won't be an option anymore with the new one :)

@parlough parlough merged commit 9a824ff into main Feb 14, 2024
8 checks passed
@parlough parlough deleted the fix/migrate-iterables-codelab branch February 14, 2024 17:19
atsansone pushed a commit to atsansone/site-www that referenced this pull request Feb 20, 2024
- Removes usage of multi-file DartPad support (tests, hints, solutions)
- Introduces new separate **Hint** and **Solution** details-based
dropdowns

Contributes to dart-lang#5382
atsansone pushed a commit to atsansone/site-www that referenced this pull request Mar 22, 2024
- Removes usage of multi-file DartPad support (tests, hints, solutions)
- Introduces new separate **Hint** and **Solution** details-based
dropdowns

Contributes to dart-lang#5382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants