Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate async/await codelab away from multi-file #5544

Merged
merged 6 commits into from
Feb 14, 2024

Conversation

parlough
Copy link
Member

@parlough parlough commented Feb 14, 2024

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Feb 14, 2024

Visit the preview URL for this PR (updated for commit 5d8b11a):

https://dart-dev--pr5544-fix-migrate-async-await-codelab-2xqkqhcr.web.app

@parlough parlough changed the title [WIP] Migrate async/await codelab away from multi-file Migrate async/await codelab away from multi-file Feb 14, 2024
@parlough parlough marked this pull request as ready for review February 14, 2024 19:52
Copy link
Contributor

@atsansone atsansone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Add info that explains that there may be some errors in the DartPad because the developer hasn't written anything. Note the difference in DartPad look and feel if possible.

@atsansone atsansone assigned parlough and unassigned MaryaBelanger Feb 14, 2024
@atsansone atsansone added the st.RFM.% Ready to Merge but has suggestions label Feb 14, 2024
@parlough parlough removed the st.RFM.% Ready to Merge but has suggestions label Feb 14, 2024
@parlough parlough merged commit 26898a5 into main Feb 14, 2024
8 checks passed
@parlough parlough deleted the fix/migrate-async-await-codelab branch February 14, 2024 20:42
atsansone pushed a commit to atsansone/site-www that referenced this pull request Feb 20, 2024
atsansone pushed a commit to atsansone/site-www that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants