Add custom styles for details-based dropdowns #5545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 490db64): https://dart-dev--pr5545-feat-details-styling-imoer7pa.web.app |
parlough
requested review from
ericwindmill,
atsansone and
MaryaBelanger
and removed request for
atsansone and
ericwindmill
|
Reassigning to Marya since it's relevant to other work she's reviewing. Thanks! @MaryaBelanger This is to make the details-based dropdowns look a bit less cramped and have a more accessible interaction style. Especially since in the iterables codelab I added one for hint and solution. |
MaryaBelanger
approved these changes
Feb 14, 2024
atsansone
pushed a commit
to atsansone/site-www
that referenced
this pull request
Feb 20, 2024
Adds interaction styles and spacing to the details summary as well as spacing to the contents. An example of how this effects on a details usage on hover at `/language/isolates#complete-example`: <img width="984" alt="Hovering over the summary of a details dropdown" src="https://github.com/dart-lang/site-www/assets/18372958/8264ff11-cbea-4d51-8de2-f38b21b9a4e9"> Contributes to dart-lang#5382 which will use `<details>` as a replacement in some cases.
atsansone
pushed a commit
to atsansone/site-www
that referenced
this pull request
Mar 22, 2024
Adds interaction styles and spacing to the details summary as well as spacing to the contents. An example of how this effects on a details usage on hover at `/language/isolates#complete-example`: <img width="984" alt="Hovering over the summary of a details dropdown" src="https://github.com/dart-lang/site-www/assets/18372958/8264ff11-cbea-4d51-8de2-f38b21b9a4e9"> Contributes to dart-lang#5382 which will use `<details>` as a replacement in some cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds interaction styles and spacing to the details summary as well as spacing to the contents.
An example of how this effects on a details usage on hover at https://dart-dev--pr5545-feat-details-styling-imoer7pa.web.app/language/isolates#complete-example:
Contributes to #5382 which will use
<details>as a replacement in some cases.