[coverage] Fix isolate resumption after service disposal

[liamappelbe]

The sequence of events that reproduces the bug is:

1. Main isolate starts
2. Main isolate spawns other isolates
3. Other isolates pause, are collected, and exit
4. IsolatePausedListener._allNonMainIsolatesExited is completed, so IsolatePausedListener.waitUntilAllExited starts waiting on IsolatePausedListener._mainIsolatePaused.
5. Main isolate spawns more isolates
6. Main isolate pauses
7. IsolatePausedListener._mainIsolatePaused is completed, so IsolatePausedListener.waitUntilAllExited collects and resumes the main isolate
8. The main isolate has exited, so the VM shuts down, and the VM service connection is disposed
9. The remaining isolates pause, so IsolatePausedListener tries to collect and resume them, causing the exception seen in the bug.

Step 5 is the bit I didn't consider when writing the new flow. The fix is just to make _allNonMainIsolatesExited wait for main to pause (logically this future is now _allNonMainIsolatesExitedAndMainIsolatePaused, but that's a bit verbose).

Details:

• We're already calling _checkCompleted() when main is paused (to fix a different edge case), so we're still going to complete the _allNonMainIsolatesExited future even if all the non-main isolates exit before main pauses.
• In some sequences (see test), the other isolates in main's group are collected before main, so main's _runCallbackAndResume() call now has to check if main's group has already been collected.

Fixes #685

[github-actions]

Package publishing

Package	Version	Status	Publish tag (post-merge)
package:coverage	1.11.0	ready to publish	coverage-v1.11.0
package:bazel_worker	1.1.3-wip	WIP (no publish necessary)
package:benchmark_harness	2.3.1	already published at pub.dev
package:boolean_selector	2.1.2	already published at pub.dev
package:browser_launcher	1.1.3	already published at pub.dev
package:cli_config	0.2.1-wip	WIP (no publish necessary)
package:cli_util	0.4.2	already published at pub.dev
package:clock	1.1.2	already published at pub.dev
package:code_builder	4.10.1	already published at pub.dev
package:csslib	1.0.2	already published at pub.dev
package:extension_discovery	2.1.0	already published at pub.dev
package:file	7.0.1	already published at pub.dev
package:file_testing	3.0.2	already published at pub.dev
package:graphs	2.3.3-wip	WIP (no publish necessary)
package:html	0.15.5	already published at pub.dev
package:json_rpc_2	3.0.3	already published at pub.dev
package:mime	2.0.0	already published at pub.dev
package:oauth2	2.0.4-wip	WIP (no publish necessary)
package:source_map_stack_trace	2.1.3-wip	WIP (no publish necessary)
package:unified_analytics	6.1.4	already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

[github-actions]

PR Health

Breaking changes ✔️

Package	Change	Current Version	New Version	Needed Version	Looking good?
coverage	None	1.10.0	1.11.0	1.10.0	✔️

Changelog Entry ✔️

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️

File	Coverage
pkgs/coverage/lib/src/isolate_paused_listener.dart	💚 98 %

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbols

License Headers ✔️

// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers

Files
pkgs/bazel_worker/benchmark/benchmark.dart
pkgs/bazel_worker/example/client.dart
pkgs/bazel_worker/example/worker.dart
pkgs/bazel_worker/lib/src/worker_protocol.pb.dart
pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart
pkgs/boolean_selector/example/example.dart
pkgs/clock/lib/clock.dart
pkgs/clock/lib/src/clock.dart
pkgs/clock/lib/src/default.dart
pkgs/clock/lib/src/stopwatch.dart
pkgs/clock/lib/src/utils.dart
pkgs/clock/test/clock_test.dart
pkgs/clock/test/default_test.dart
pkgs/clock/test/stopwatch_test.dart
pkgs/clock/test/utils.dart
pkgs/html/example/main.dart
pkgs/html/lib/dom.dart
pkgs/html/lib/dom_parsing.dart
pkgs/html/lib/html_escape.dart
pkgs/html/lib/parser.dart
pkgs/html/lib/src/constants.dart
pkgs/html/lib/src/encoding_parser.dart
pkgs/html/lib/src/html_input_stream.dart
pkgs/html/lib/src/list_proxy.dart
pkgs/html/lib/src/query_selector.dart
pkgs/html/lib/src/token.dart
pkgs/html/lib/src/tokenizer.dart
pkgs/html/lib/src/treebuilder.dart
pkgs/html/lib/src/utils.dart
pkgs/html/test/dom_test.dart
pkgs/html/test/parser_feature_test.dart
pkgs/html/test/parser_test.dart
pkgs/html/test/query_selector_test.dart
pkgs/html/test/selectors/level1_baseline_test.dart
pkgs/html/test/selectors/level1_lib.dart
pkgs/html/test/selectors/selectors.dart
pkgs/html/test/support.dart
pkgs/html/test/tokenizer_test.dart

[coveralls]

Pull Request Test Coverage Report for Build 11716029981

Details

• 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.05%) to 93.037%

---

Totals
Change from base Build 11670808043:	0.05%
Covered Lines:	628
Relevant Lines:	675

---

💛 - Coveralls