Uncomment some tests #145
Merged
Uncomment some tests #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests had been commented out since the original commit in this repo even though most of them would pass. With these tests commented out the suite has an empty `group` which may become disallowed. dart-lang/test#1961 Change double quotes to single quotes. Skip a test which is currently failing due to an error parsing a float value with a single digit.
kevmoo
approved these changes
May 10, 2023
|
Good find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests had been commented out since the original commit in this
repo even though most of them would pass.
With these tests commented out the suite has an empty
groupwhich maybecome disallowed.
dart-lang/test#1961
Change double quotes to single quotes.
Skip a test which is currently failing due to an error parsing a float
value with a single digit.