Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with ggplot2 #6

Closed
wants to merge 1 commit into from

Conversation

teunbrand
Copy link

Hi there,

Apologies for not posting an issue first.
The ggplot2 package is planning an update for around May 2025 and a reverse dependency test identified a problem with the visOmopResults package.
The details are explained in tidyverse/ggplot2#6290, but essentially ggplot2 doesn't populate the plot$labels field before plot building anymore, which violates some test assumptions in this package.

This PR changes the tests to be compatible with both versions of ggplot2.
You can test the changes yourself with the development version of ggplot2 (pak::pak("tidyverse/ggplot2"))

Best,
Teun

@nmercadeb
Copy link
Collaborator

Thank you for the PR addressing the test updates for the new ggplot2 release. We will incorporate these changes in an upcoming release. For now, I am closing the PR, as the implementation will be handled in the development repository and updated here alongside the next CRAN release.

Thanks again!
Núria

@nmercadeb nmercadeb closed this Feb 5, 2025
@teunbrand
Copy link
Author

Thanks, I'm glad to know the issue is on your radar!

@teunbrand teunbrand deleted the ggplot2_360 branch February 5, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants