chore: improve container image build times #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basti1302
force-pushed
the
improve-build-times
branch
5 times, most recently
from
78cf6f7 to
4d9c3a1
Compare
basti1302
force-pushed
the
improve-build-times
branch
from
4d9c3a1 to
4a7c5e2
Compare
Essentially this adds --platform=${BUILDPLATFORM} to the FROM
instruction for the build stage. This makes that stage run on the
platform of the underlying machine instead running in the target
platform/architecture. We then let the Go compiler take care of
producing a binary for the target platform by setting GOARCH to
TARGETPLATFORM.
This massively speeds up multi-platform builds, as it removes the need
for emulation in the compilation phase.
Before, building all images for both platforms (x86_64 and arm64) on
cold caches via GitHub actions would take around 1:13 h, with individual
image build times roughly as follows:
- operator controller: 15 minutes
- instrumentation: 4 minutes
- collector: 37 minutes
- configuration reloader: 4 minutes
- filelog offset synch: 11 minutes
With this change, building all images for both platforms (x86_64 and
arm64) on cold caches via GitHub actions takes only 16 minutes, with
individual image build times roughly as follows:
- operator controller: 3 minutes
- instrumentation: 4 minutes
- collector: 6 minutes
- configuration reloader: 1 minute
- filelog offset synch: 2 minutes
Note: The instrumentation image is not yet migrated to this new
strategy.
basti1302
force-pushed
the
improve-build-times
branch
from
4a7c5e2 to
7c43108
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.