fix(injector, prometheus): drop service.instance.id mappings #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up to 9bb9fc0.
Do not map the Kubernetes label app.kubernetes.io/instance to the resource attribute service.instance.id, neither for Prometheus scraping nor when mapping workload level labels to resource attributes via the injector. Also: Only derive service.namespace and service.version from app.kubernetes.io/version and serivce.namespace from app.kubernetes.io/part_of respectively if we also derive service.name.
Add tests for the app.kubernetes.io/* and resource.opentelemetry.io/* labels.
basti1302
force-pushed
the
do-not-map-k8s-label-to-service-instance-id
branch
from
5043f53 to
935bace
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not map the Kubernetes label app.kubernetes.io/instance to the
resource attribute service.instance.id, neither for Prometheus scraping
nor when mapping workload level labels to resource attributes via the
injector.
Also: Only derive service.namespace and service.version from
app.kubernetes.io/version and serivce.namespace from
app.kubernetes.io/part_of respectively if we also derive service.name.