Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add correct start options to batcher spec #350

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

Ziinc
Copy link
Contributor

@Ziinc Ziinc commented Mar 3, 2025

This PR adds in correct start options for the batcher spec, properly propagating the start options.

@Ziinc Ziinc changed the title fix: add fullsweep_after to batcher spec fix: add correct start options to batcher spec Mar 3, 2025
@josevalim josevalim merged commit 5460218 into dashbitco:main Mar 3, 2025
2 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@coveralls
Copy link

Pull Request Test Coverage Report for Build db1f89ece26e9eae9a4e494e8edb14b8d3396174-PR-350

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.119%

Totals Coverage Status
Change from base Build 41df5799011ce1734d50b7c1f08db0327dc1f2c0: 0.0%
Covered Lines: 636
Relevant Lines: 683

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants