-
Notifications
You must be signed in to change notification settings - Fork 21
feat(documents): allow to retrieve a document by its ID #116
base: v0.22-dev
Are you sure you want to change the base?
Conversation
Looks good to me! What do you think @shumkov @Alex-Werner ? |
#103 had a brief discussion if it's worthwhile to rename the methods to e.g. there is also a brief convo on discord on it of course it can always be changed later |
@dashameter Yeah, I guess we can do that later. Regarding |
accepting a |
I would keep just one method. |
What if we merge this as is, since I'm already using the method in the dapps, and later we extend it with an array of ids which will be a non breaking change, since the function will continue to also accept just a single ID as a string. |
Polymorphic params in defo, not a best practice. I meant to make the method accept only array of IDs and call it |
Issue being fixed or feature implemented
Add shorthand method to retrieve documents by their
$id
Example:
closes #102
supersedes #103