ref: ditch confusing dependency injection #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolaj86
force-pushed
the
ref-false-deps
branch
4 times, most recently
from
0b25724 to
48f0bfa
Compare
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@types/[email protected], npm/[email protected] |
coolaj86
force-pushed
the
ref-false-deps
branch
from
48f0bfa to
0894215
Compare
coolaj86
force-pushed
the
ref-false-deps
branch
from
a9156ec to
9906291
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
https://github.com/dashhive/DashTx.js/tree/ref-false-deps
Why?
This has caused issues with false positive missing dependency warnings in bundlers, and it's just confusing to look at.
Nixing.
Although this reduces convenience, DashTx isn't meant to be convenient - it's meant to be accurate. Wallet libraries built atop DashTx will make it convenient.