Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes & Enhancements for Stage 1 QA Feedback #31

Merged
merged 48 commits into from
Feb 24, 2024
Merged
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
467fc0b
docs: :memo: Update TODO's
jojobyte Feb 7, 2024
06e6dd6
fix(ui): :adhesive_bandage: diable autocomplete & update style for Ke…
jojobyte Feb 7, 2024
0724ba0
fix(ui): :bug: alias bg, remeber pass & better keyboard nav
jojobyte Feb 8, 2024
393e3df
Merge branch 'master' of github.com:dashhive/wallet-ui into fix/stage…
jojobyte Feb 8, 2024
221bc29
fix(ui): :bug: make contact list keyboard navigable
jojobyte Feb 8, 2024
c0325b9
fix(ui): :lipstick: set `line-height` for dialog btns
jojobyte Feb 8, 2024
a934aef
style(ui): :lipstick: change disconnect bomb to broom
jojobyte Feb 8, 2024
42283ca
fix(ui): :speech_balloon: Change Request to Receive
jojobyte Feb 8, 2024
569318a
fix: :construction: try to fix qr scanner
jojobyte Feb 8, 2024
039c966
docs: :memo: complete lock btn todo item
jojobyte Feb 8, 2024
5545717
docs: :memo: complete qr pairing todo item
jojobyte Feb 8, 2024
14aa58f
fix: :construction: fix qr scan for send dialog
jojobyte Feb 8, 2024
626a5f9
fix: :construction: get amount from send qr scan
jojobyte Feb 8, 2024
39836bb
fix(ui): :lipstick: improve upload styling
jojobyte Feb 8, 2024
6124858
fix(ui): :children_crossing: change amount validation in send & recei…
jojobyte Feb 10, 2024
cebcc09
fix(ui): :children_crossing: add bg color based on contact name or alias
jojobyte Feb 10, 2024
84350ca
fix: :children_crossing: async dialog content & fix onboarding import…
jojobyte Feb 10, 2024
5afad8a
fix(ui): :children_crossing: improve errors for alias & style of keys…
jojobyte Feb 10, 2024
196b4a7
fix: :construction: attempt to fix iOS zoom issue with `maximum-scale=1`
jojobyte Feb 10, 2024
a10e6f9
fix(ui): :bug: change request to receive
jojobyte Feb 10, 2024
9420124
fix(ui): :bug: fix dialog name collision breaking generate new phrase
jojobyte Feb 11, 2024
6aa694b
fix: :bug: closes #37 input amount insert preceding 0 & fix validation
jojobyte Feb 11, 2024
0b654d4
fix(ui): :children_crossing: use default avatar bg color for unpaired…
jojobyte Feb 11, 2024
4cc1303
fix(ui): :children_crossing: keyboard tab focus on keystore related t…
jojobyte Feb 11, 2024
46ce8cc
fix(ui): :children_crossing: clear selected file (keystore/backup) cl…
jojobyte Feb 14, 2024
4e6f3f9
refactor: :fire: remove `input-amount` component
jojobyte Feb 14, 2024
0d0ec89
feat(ui): :sparkles: add tx info dialog after send
jojobyte Feb 14, 2024
1ab2acf
docs: :memo: update TODO's
jojobyte Feb 14, 2024
f32de30
docs: :memo: Add newley discovered bugs to TODO
jojobyte Feb 14, 2024
cd06607
fix(ui): :iphone: import button fix for mobile
jojobyte Feb 14, 2024
6c96982
fix: :construction: try to fix initial funding issue
jojobyte Feb 14, 2024
0ceebef
fix(data): :construction: disable `DashSocket` debug
jojobyte Feb 19, 2024
a65404b
style(ui): :lipstick: mobile fixes for insufficient funds and dialog …
jojobyte Feb 19, 2024
84f920a
fix(ui): improve funding label text
jojobyte Feb 19, 2024
19d068c
docs: :memo: verify bug fix and update todos
jojobyte Feb 19, 2024
89e2735
docs: :memo: Roadmap & TODO Updates
jojobyte Feb 19, 2024
3801ae3
feat(ui): :sparkles: add amount percentage buttons (25%, 50%, 75%) to…
jojobyte Feb 19, 2024
65ee57e
docs: :memo: Shift some Todos to Roadmap Backlog
jojobyte Feb 19, 2024
825d3c2
fix(ui): :lipstick: change receive funds QR flow
jojobyte Feb 20, 2024
6e5febb
feat(ui): :sparkles: enable full send and implement DashWallet.js
jojobyte Feb 20, 2024
b8ea50d
docs: :memo: fix typo
jojobyte Feb 20, 2024
aa66981
fix(ui): :sparkles: disable autocapitalize on alias input
jojobyte Feb 20, 2024
6ed6b9d
fix(ui): :bug: toggle show/hide pass
jojobyte Feb 23, 2024
f82a42b
fix(data): :bug: uri param parsing
jojobyte Feb 24, 2024
81d70c6
fix(data): :bug: change instanceof Array to Array.isArray
jojobyte Feb 24, 2024
15c3439
fix(data): :bug: change vout some to filter
jojobyte Feb 24, 2024
dd42504
fix(ui): :bug: resolve some of the issues DashWallet.js send
jojobyte Feb 24, 2024
9e5e3bd
refactor: :coffin: remove dead code
jojobyte Feb 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs: 📝 Shift some Todos to Roadmap Backlog
jojobyte committed Feb 19, 2024
commit 65ee57e63848551bc417526f762345c05adb30ea
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -112,4 +112,7 @@ A Graphical User Interface (GUI) for
- [ ] We need to support importing raw xpubs if we don’t already.
- [ ] style: Top button is “adjective noun”, bottom two buttons are “verb noun”. Maybe make it consistent.
- [ ] feat: Every time I click Request the wallet generates a new address. This might be unsettling for users. Need to rethink this functionality. Side note/question: Is this cycling through the 0 index on the HD path when no contact is selected? Either way, we may want to put our own username in the alias input box by default, which would be the default funding mechanism.
- [ ] Contact Data List Selector in the Send Dialog on mobile does not show contact alias hints
- Appears to be an issue specific to Firefox on Android, both normal version (in normal & private view) & Firefox Focus
- [ ] Edit Profile, Add Contact & Insufficient Wallet Funds Dialogs have layout issues on mobile
- [ ]
23 changes: 0 additions & 23 deletions TODO.md
Original file line number Diff line number Diff line change
@@ -13,32 +13,9 @@

### Bugs
#### Mobile Specific
- [ ] Edit Profile, Add Contact & Insufficient Wallet Funds Dialogs have layout issues on mobile
- [ ] Contact Data List Selector in the Send Dialog on mobile does not show contact alias hints
- Appears to be an issue specific to Firefox on Android, both normal version (in normal & private view) & Firefox Focus
- [x] Copy Buttons don't seem to work reliably
- [x] Unique Alias Collision with only the one contact you're trying to pair with
- Unable to verify and reproduce issue
- [x] After initial pairing between mobile & desktop wallets, we funded the wallet from an external source, no page refresh but websocket updated balance, attempting to send to mobile contact from desktop failed
- Should be fixed by https://github.com/dashhive/wallet-ui/pull/31/commits/6c96982925544aeafac470d46722a2f5bdb050d0
- tried to POST to https://insight.dash.org/insight-api/addrs/utxo with an empty `addrs` array/string
- TypeError: Cannot read properties of undefined (reading 'split')
at AddressController.checkAddrs (/insight/node_modules/@dashevo/insight-api/lib/addresses.js:100:34)
at Layer.handle [as handle_request] (/insight/node_modules/express/lib/router/layer.js:95:5)
at next (/insight/node_modules/express/lib/router/route.js:144:13)
at /insight/node_modules/@dashevo/insight-api/lib/index.js:78:5
at Layer.handle [as handle_request] (/insight/node_modules/express/lib/router/layer.js:95:5)
at next (/insight/node_modules/express/lib/router/route.js:144:13)
at Route.dispatch (/insight/node_modules/express/lib/router/route.js:114:3)
at Layer.handle [as handle_request] (/insight/node_modules/express/lib/router/layer.js:95:5)
at /insight/node_modules/express/lib/router/index.js:284:15
at Function.process_params (/insight/node_modules/express/lib/router/index.js:346:12)
- [ ]

### Enhancements
- [x] Dialog: Sent Funds Confirmation
- currently send closes, and you see your balance change
- we should show a "Funds Sent" type dialog with a link to the Transaction ID
- [ ] Batch Generate tweaks
- need to check each address funds and generate 20 past the last address with funds
- need to pre-generate accounts with some addresses when importing a phrase to start adding contacts after the last account with funds