Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for CrowdNode 3rd party integration #76

Open
wants to merge 13 commits into
base: feat/3rd-party-crowdnode
Choose a base branch
from

Conversation

jojobyte
Copy link
Contributor

This is a massive refactor to fix the internal state of several components, which were not correctly updating/resetting when some dialogs would close, as well as to move contact creation/updating out of the dialogs so that we can programatically create a contact without user interaction.

This is particularly useful for creating a CrowdNode or Maya contact, where the user shouldn't need to know the Address/Contact information.

The internal state of several components was not correctly updating/resetting when some dialogs would close. this is a massive refactor to fix some of those underlying issues as well as move contact creation/updating out of the dialog so that we can programatically create a contact without user interaction, specifically useful for creating a crowdnode or maya contact.
@jojobyte jojobyte self-assigned this Oct 31, 2024
Copy link

gitguardian bot commented Dec 28, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11479664 Triggered Generic Password 798cd61 src/rigs/wallet-decrypt.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant