Skip to content

Commit

Permalink
ci: Run tests in container
Browse files Browse the repository at this point in the history
  • Loading branch information
dashmug committed Feb 20, 2024
1 parent 85c551c commit 2da54d9
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 11 deletions.
26 changes: 16 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,45 +16,52 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/[email protected]

- name: Setup Virtualenv Cache
uses: actions/[email protected]
with:
path: .venv
key: ${{ runner.os }}-poetry-${{ hashFiles('poetry.lock') }}
restore-keys: |
${{ runner.os }}-poetry-
- name: Set up Python 3.10
uses: actions/[email protected]
with:
python-version: "3.10.13"

- name: Setup Poetry
uses: Gr1N/setup-poetry@v9

- name: Install Python Dependencies
run: poetry install --no-root

- name: Check poetry config
run: poetry check

- name: Lint Python code
run: |
poetry run ruff format . --check
poetry run ruff check .
- name: Check type annotations
run: poetry run mypy

- name: Check if requirements.txt is up-to-date
run: poetry export --output requirements.txt | git diff --exit-code
Container:
name: Container
runs-on: ubuntu-latest
steps:
- uses: actions/[email protected]
- name: Run the checks inside Docker
uses: addnab/docker-run-action@v3
with:
image: amazon/aws-glue-libs:glue_libs_4.0.0_image_01
options: --volume ${{ github.workspace }}:/home/glue_user/workspace
run: |
pip3 install --user --upgrade pip==24.0
pip3 install --user -r requirements.txt
/home/glue_user/.local/bin/ruff format . --check --no-cache
/home/glue_user/.local/bin/ruff check . --no-cache
/home/glue_user/.local/bin/mypy
shell:
name: Shell
runs-on: ubuntu-latest
steps:
- uses: actions/[email protected]

- name: Check shell scripts
uses: ludeeus/[email protected]
with:
Expand All @@ -64,7 +71,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/[email protected]

- name: Validate Dockerfile using hadolint
uses: hadolint/[email protected]

2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ FROM amazon/aws-glue-libs:glue_libs_4.0.0_image_01
ENV PLATFORM="docker"

# Arguments for passing the host user:group to the container.
ARG USER_ID
ARG USER_ID=1000

# Switch to root to be able to make changes in the container filesystem.
USER root
Expand Down

0 comments on commit 2da54d9

Please sign in to comment.