Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Restore coverage measurement #16

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Conversation

dashmug
Copy link
Owner

@dashmug dashmug commented Feb 23, 2024

Closes #15 .

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: This pull request introduces a new feature to generate test coverage HTML reports. It updates the Makefile to add a new coverage target that conditionally executes different commands based on the PLATFORM environment variable. Additionally, it updates the README.md to include the new coverage command in the list of available commands.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

  • The PR successfully adds a new feature for generating test coverage reports, enhancing the project's testing infrastructure. However, there's a critical issue identified in the Makefile where a recursive call could potentially lead to an infinite loop under certain conditions. It's recommended to address this issue to ensure the new feature works reliably across all environments.
  • Consider adding more context or examples in the README.md on how the coverage reports can be utilized or interpreted by developers. This could improve the usability of the new feature.
  • Review the implementation of the coverage target in the Makefile to ensure it's optimized for all supported platforms and does not introduce any unintended behavior.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@pytest --cov=src --cov=glue_utils --cov-branch --cov-report=term
@coverage html
else
@$(COMPOSE_RUN) -c "make coverage"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (llm): The recursive call to make coverage within the Docker condition might lead to an infinite loop if the PLATFORM variable remains set to docker within the Docker environment. Consider verifying or setting a different mechanism to avoid potential infinite recursion.

@dashmug dashmug force-pushed the refactor-managed-glue-context branch from 2449ba5 to 3982e34 Compare February 23, 2024 09:07
@dashmug dashmug merged commit 2b3b2c5 into main Feb 23, 2024
6 checks passed
@dashmug dashmug deleted the refactor-managed-glue-context branch February 23, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring back coverage measurement.
1 participant