Merge pull request #3818 from UdjinM6/hotfix1611

Hotfix 0.16.1.1
dashpay · Nov 15, 2020 · 43d2973 · 43d2973
2 parents 67624ec + 1734872
commit 43d2973
Show file tree

Hide file tree

Showing 12 changed files with 185 additions and 64 deletions.
diff --git a/configure.ac b/configure.ac
@@ -3,7 +3,7 @@ AC_PREREQ([2.60])
 define(_CLIENT_VERSION_MAJOR, 0)
 define(_CLIENT_VERSION_MINOR, 16)
 define(_CLIENT_VERSION_REVISION, 1)
-define(_CLIENT_VERSION_BUILD, 0)
+define(_CLIENT_VERSION_BUILD, 1)
 define(_CLIENT_VERSION_IS_RELEASE, true)
 define(_COPYRIGHT_YEAR, 2020)
 define(_COPYRIGHT_HOLDERS,[The %s developers])

diff --git a/doc/man/dash-cli.1 b/doc/man/dash-cli.1
@@ -1,9 +1,9 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.47.16.
-.TH DASH-CLI "1" "November 2020" "dash-cli v0.16.1.0" "User Commands"
+.TH DASH-CLI "1" "November 2020" "dash-cli v0.16.1.1" "User Commands"
 .SH NAME
-dash-cli \- manual page for dash-cli v0.16.1.0
+dash-cli \- manual page for dash-cli v0.16.1.1
 .SH DESCRIPTION
-Dash Core RPC client version v0.16.1.0
+Dash Core RPC client version v0.16.1.1
 .SS "Usage:"
 .TP
 dash\-cli [options] <command> [params]

diff --git a/doc/man/dash-qt.1 b/doc/man/dash-qt.1
@@ -1,9 +1,9 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.47.16.
-.TH DASH-QT "1" "November 2020" "dash-qt v0.16.1.0" "User Commands"
+.TH DASH-QT "1" "November 2020" "dash-qt v0.16.1.1" "User Commands"
 .SH NAME
-dash-qt \- manual page for dash-qt v0.16.1.0
+dash-qt \- manual page for dash-qt v0.16.1.1
 .SH DESCRIPTION
-Dash Core version v0.16.1.0 (64\-bit)
+Dash Core version v0.16.1.1 (64\-bit)
 Usage:
 .IP
 dash\-qt [command\-line options]

diff --git a/doc/man/dash-tx.1 b/doc/man/dash-tx.1
@@ -1,9 +1,9 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.47.16.
-.TH DASH-TX "1" "November 2020" "dash-tx v0.16.1.0" "User Commands"
+.TH DASH-TX "1" "November 2020" "dash-tx v0.16.1.1" "User Commands"
 .SH NAME
-dash-tx \- manual page for dash-tx v0.16.1.0
+dash-tx \- manual page for dash-tx v0.16.1.1
 .SH DESCRIPTION
-Dash Core dash\-tx utility version v0.16.1.0
+Dash Core dash\-tx utility version v0.16.1.1
 .SS "Usage:"
 .TP
 dash\-tx [options] <hex\-tx> [commands]

diff --git a/doc/man/dashd.1 b/doc/man/dashd.1
@@ -1,9 +1,9 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.47.16.
-.TH DASHD "1" "November 2020" "dashd v0.16.1.0" "User Commands"
+.TH DASHD "1" "November 2020" "dashd v0.16.1.1" "User Commands"
 .SH NAME
-dashd \- manual page for dashd v0.16.1.0
+dashd \- manual page for dashd v0.16.1.1
 .SH DESCRIPTION
-Dash Core Daemon version v0.16.1.0
+Dash Core Daemon version v0.16.1.1
 .SS "Usage:"
 .TP
 dashd [options]

diff --git a/doc/release-notes.md b/doc/release-notes.md
@@ -1,11 +1,11 @@
-Dash Core version 0.16.1.0
+Dash Core version 0.16.1.1
 ==========================
 
 Release is now available from:
 
   <https://www.dash.org/downloads/#wallets>
 
-This is a new minor version release, bringing various bugfixes and improvements.
+This is a new hotfix release.
 
 Please report bugs using the issue tracker at github:
 
@@ -49,56 +49,22 @@ so downgrading is not recommended.
 Notable changes
 ===============
 
-Network changes
----------------
-InstantSend locks were not relayed correctly when another node was requesting updates via the `mempool`
-p2p message. Some other internal optimizations were made to the way object requests are handled.
-
-GUI changes
------------
-Fixes for the following GUI related issues
-- The wallet crashed if no valid GUI theme was found in settings.
-This happened for users upgrading from versions prior to v0.14.
-- There were randomly occurring font size scaling issues.
-- Opening or closing the settings while the application was in full-screen/maximized
-window mode lead to fragmented GUI layouts.
-- There was an unexpected checkmark in the "Encrypt wallet" menu item on Linux and Windows
-- Starting Dash Core compiled without wallet support or with `-disablewallet` command line
-parameter lead to an application crash.
-
-RPC changes
------------
-- `getwalletinfo` shows wallet rescan duration and progress now
-
-0.16.1.0 Change log
+There was an unexpected behaviour of the "Encrypt wallet" menu item for unencrypted wallets
+which was showing users the "Decrypt wallet" dialog instead. This was a GUI only issue,
+internal encryption logic and RPC behaviour were not affected.
+
+0.16.1.1 Change log
 ===================
 
-See detailed [set of changes](https://github.com/dashpay/dash/compare/v0.16.0.1...dashpay:v0.16.1.0).
-
-- [`b1c930bc86`](https://github.com/dashpay/dash/commit/b1c930bc86) [v0.16.x] bump version in configure.ac (#3788)
-- [`3d94e714a9`](https://github.com/dashpay/dash/commit/3d94e714a9) contrib|src: Update hard coded seeds (#3791)
-- [`c02a994489`](https://github.com/dashpay/dash/commit/c02a994489) bump nMinimumChainWork, defaultAssumeValid, checkpointData for mainnet and testnet (#3789)
-- [`1d41fbd760`](https://github.com/dashpay/dash/commit/1d41fbd760) Update man pages (#3798)
-- [`b3bbc00dbc`](https://github.com/dashpay/dash/commit/b3bbc00dbc) Merge #15730: rpc: Show scanning details in getwalletinfo (#3785)
-- [`3ad4651db1`](https://github.com/dashpay/dash/commit/3ad4651db1) Call EraseObjectRequest as soon as an object is read from the stream (#3783)
-- [`d8f8f174c0`](https://github.com/dashpay/dash/commit/d8f8f174c0) Avoid accessing pendingContributionVerifications from VerifyPendingContributions while ReceiveMessage is still doing its job (#3782)
-- [`0814e6145d`](https://github.com/dashpay/dash/commit/0814e6145d) qt: Handle fonts of deleted widgets properly, streamline the flow in `GUIUtil::updateFonts` (#3772)
-- [`e149740120`](https://github.com/dashpay/dash/commit/e149740120) qt: avoid auto-updating window width when it's in full screen or when it's maximized (#3771)
-- [`78358a2a6d`](https://github.com/dashpay/dash/commit/78358a2a6d) qt: Do not show a check-mark for "Encrypt wallet" menu item (#3770)
-- [`7b72e98092`](https://github.com/dashpay/dash/commit/7b72e98092) Fix IS-locks sync via `mempool` p2p command (#3766)
-- [`9ceee5df20`](https://github.com/dashpay/dash/commit/9ceee5df20) qt: Fix --disable-wallet build and --disablewallet mode (#3762)
-- [`62985c771b`](https://github.com/dashpay/dash/commit/62985c771b) depends: Update Qt download url. (#3756)
-- [`717a41a572`](https://github.com/dashpay/dash/commit/717a41a572) qt: Make sure there is a valid theme set in the options (#3755)
-- [`01a3435158`](https://github.com/dashpay/dash/commit/01a3435158) update public part of windows code signing certificate (#3749)
+See detailed [set of changes](https://github.com/dashpay/dash/compare/v0.16.1.0...dashpay:v0.16.1.1).
+
+- [`ccef3b4836`](https://github.com/dashpay/dash/commit/ccef3b48363d8bff4b919d9119355182e3902ef3) qt: Fix wallet encryption dialog (#3816)
 
 Credits
 =======
 
 Thanks to everyone who directly contributed to this release:
 
-- dustinface (xdustinface)
-- Oleg Girko (OlegGirko)
-- PastaPastaPasta
 - UdjinM6
 
 As well as everyone that submitted issues and reviewed pull requests.
@@ -126,6 +92,7 @@ Dash Core tree 0.12.1.x was a fork of Bitcoin Core tree 0.12.
 
 These release are considered obsolete. Old release notes can be found here:
 
+- [v0.16.1.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.16.1.0.md) released November/14/2020
 - [v0.16.0.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.16.0.1.md) released September/30/2020
 - [v0.15.0.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.15.0.0.md) released Febrary/18/2020
 - [v0.14.0.5](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.5.md) released December/08/2019

diff --git a/doc/release-notes/dash/release-notes-0.16.1.0.md b/doc/release-notes/dash/release-notes-0.16.1.0.md
@@ -0,0 +1,154 @@
+Dash Core version 0.16.1.0
+==========================
+
+Release is now available from:
+
+  <https://www.dash.org/downloads/#wallets>
+
+This is a new minor version release, bringing various bugfixes and improvements.
+
+Please report bugs using the issue tracker at github:
+
+  <https://github.com/dashpay/dash/issues>
+
+
+Upgrading and downgrading
+=========================
+
+How to Upgrade
+--------------
+
+If you are running an older version, shut it down. Wait until it has completely
+shut down (which might take a few minutes for older versions), then run the
+installer (on Windows) or just copy over /Applications/Dash-Qt (on Mac) or
+dashd/dash-qt (on Linux). If you upgrade after DIP0003 activation and you were
+using version < 0.13 you will have to reindex (start with -reindex-chainstate
+or -reindex) to make sure your wallet has all the new data synced. Upgrading
+from version 0.13 should not require any additional actions.
+
+When upgrading from a version prior to 0.14.0.3, the
+first startup of Dash Core will run a migration process which can take a few
+minutes to finish. After the migration, a downgrade to an older version is only
+possible with a reindex (or reindex-chainstate).
+
+Downgrade warning
+-----------------
+
+### Downgrade to a version < 0.14.0.3
+
+Downgrading to a version older than 0.14.0.3 is no longer supported due to
+changes in the "evodb" database format. If you need to use an older version,
+you must either reindex or re-sync the whole chain.
+
+### Downgrade of masternodes to < 0.16
+
+Starting with this release, masternodes will verify the protocol version of other
+masternodes. This will result in PoSe punishment/banning for outdated masternodes,
+so downgrading is not recommended.
+
+Notable changes
+===============
+
+Network changes
+---------------
+InstantSend locks were not relayed correctly when another node was requesting updates via the `mempool`
+p2p message. Some other internal optimizations were made to the way object requests are handled.
+
+GUI changes
+-----------
+Fixes for the following GUI related issues
+- The wallet crashed if no valid GUI theme was found in settings.
+This happened for users upgrading from versions prior to v0.14.
+- There were randomly occurring font size scaling issues.
+- Opening or closing the settings while the application was in full-screen/maximized
+window mode lead to fragmented GUI layouts.
+- There was an unexpected checkmark in the "Encrypt wallet" menu item on Linux and Windows
+- Starting Dash Core compiled without wallet support or with `-disablewallet` command line
+parameter lead to an application crash.
+
+RPC changes
+-----------
+- `getwalletinfo` shows wallet rescan duration and progress now
+
+0.16.1.0 Change log
+===================
+
+See detailed [set of changes](https://github.com/dashpay/dash/compare/v0.16.0.1...dashpay:v0.16.1.0).
+
+- [`b1c930bc86`](https://github.com/dashpay/dash/commit/b1c930bc86) [v0.16.x] bump version in configure.ac (#3788)
+- [`3d94e714a9`](https://github.com/dashpay/dash/commit/3d94e714a9) contrib|src: Update hard coded seeds (#3791)
+- [`c02a994489`](https://github.com/dashpay/dash/commit/c02a994489) bump nMinimumChainWork, defaultAssumeValid, checkpointData for mainnet and testnet (#3789)
+- [`1d41fbd760`](https://github.com/dashpay/dash/commit/1d41fbd760) Update man pages (#3798)
+- [`b3bbc00dbc`](https://github.com/dashpay/dash/commit/b3bbc00dbc) Merge #15730: rpc: Show scanning details in getwalletinfo (#3785)
+- [`3ad4651db1`](https://github.com/dashpay/dash/commit/3ad4651db1) Call EraseObjectRequest as soon as an object is read from the stream (#3783)
+- [`d8f8f174c0`](https://github.com/dashpay/dash/commit/d8f8f174c0) Avoid accessing pendingContributionVerifications from VerifyPendingContributions while ReceiveMessage is still doing its job (#3782)
+- [`0814e6145d`](https://github.com/dashpay/dash/commit/0814e6145d) qt: Handle fonts of deleted widgets properly, streamline the flow in `GUIUtil::updateFonts` (#3772)
+- [`e149740120`](https://github.com/dashpay/dash/commit/e149740120) qt: avoid auto-updating window width when it's in full screen or when it's maximized (#3771)
+- [`78358a2a6d`](https://github.com/dashpay/dash/commit/78358a2a6d) qt: Do not show a check-mark for "Encrypt wallet" menu item (#3770)
+- [`7b72e98092`](https://github.com/dashpay/dash/commit/7b72e98092) Fix IS-locks sync via `mempool` p2p command (#3766)
+- [`9ceee5df20`](https://github.com/dashpay/dash/commit/9ceee5df20) qt: Fix --disable-wallet build and --disablewallet mode (#3762)
+- [`62985c771b`](https://github.com/dashpay/dash/commit/62985c771b) depends: Update Qt download url. (#3756)
+- [`717a41a572`](https://github.com/dashpay/dash/commit/717a41a572) qt: Make sure there is a valid theme set in the options (#3755)
+- [`01a3435158`](https://github.com/dashpay/dash/commit/01a3435158) update public part of windows code signing certificate (#3749)
+
+Credits
+=======
+
+Thanks to everyone who directly contributed to this release:
+
+- dustinface (xdustinface)
+- Oleg Girko (OlegGirko)
+- PastaPastaPasta
+- UdjinM6
+
+As well as everyone that submitted issues and reviewed pull requests.
+
+Older releases
+==============
+
+Dash was previously known as Darkcoin.
+
+Darkcoin tree 0.8.x was a fork of Litecoin tree 0.8, original name was XCoin
+which was first released on Jan/18/2014.
+
+Darkcoin tree 0.9.x was the open source implementation of masternodes based on
+the 0.8.x tree and was first released on Mar/13/2014.
+
+Darkcoin tree 0.10.x used to be the closed source implementation of Darksend
+which was released open source on Sep/25/2014.
+
+Dash Core tree 0.11.x was a fork of Bitcoin Core tree 0.9,
+Darkcoin was rebranded to Dash.
+
+Dash Core tree 0.12.0.x was a fork of Bitcoin Core tree 0.10.
+
+Dash Core tree 0.12.1.x was a fork of Bitcoin Core tree 0.12.
+
+These release are considered obsolete. Old release notes can be found here:
+
+- [v0.16.0.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.16.0.1.md) released September/30/2020
+- [v0.15.0.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.15.0.0.md) released Febrary/18/2020
+- [v0.14.0.5](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.5.md) released December/08/2019
+- [v0.14.0.4](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.4.md) released November/22/2019
+- [v0.14.0.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.3.md) released August/15/2019
+- [v0.14.0.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.2.md) released July/4/2019
+- [v0.14.0.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.1.md) released May/31/2019
+- [v0.14.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.md) released May/22/2019
+- [v0.13.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.13.3.md) released Apr/04/2019
+- [v0.13.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.13.2.md) released Mar/15/2019
+- [v0.13.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.13.1.md) released Feb/9/2019
+- [v0.13.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.13.0.md) released Jan/14/2019
+- [v0.12.3.4](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.4.md) released Dec/14/2018
+- [v0.12.3.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.3.md) released Sep/19/2018
+- [v0.12.3.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.2.md) released Jul/09/2018
+- [v0.12.3.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.1.md) released Jul/03/2018
+- [v0.12.2.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.2.3.md) released Jan/12/2018
+- [v0.12.2.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.2.2.md) released Dec/17/2017
+- [v0.12.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.2.md) released Nov/08/2017
+- [v0.12.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.1.md) released Feb/06/2017
+- [v0.12.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.0.md) released Aug/15/2015
+- [v0.11.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.11.2.md) released Mar/04/2015
+- [v0.11.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.11.1.md) released Feb/10/2015
+- [v0.11.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.11.0.md) released Jan/15/2015
+- [v0.10.x](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.10.0.md) released Sep/25/2014
+- [v0.9.x](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.9.0.md) released Mar/13/2014
diff --git a/src/qt/bitcoingui.cpp b/src/qt/bitcoingui.cpp
@@ -575,7 +575,7 @@ void BitcoinGUI::createActions()
 #ifdef ENABLE_WALLET
     if(walletFrame)
     {
-        connect(encryptWalletAction, SIGNAL(triggered(bool)), walletFrame, SLOT(encryptWallet(bool)));
+        connect(encryptWalletAction, SIGNAL(triggered()), walletFrame, SLOT(encryptWallet()));
         connect(backupWalletAction, SIGNAL(triggered()), walletFrame, SLOT(backupWallet()));
         connect(changePassphraseAction, SIGNAL(triggered()), walletFrame, SLOT(changePassphrase()));
         connect(unlockWalletAction, SIGNAL(triggered()), walletFrame, SLOT(unlockWallet()));

diff --git a/src/qt/walletframe.cpp b/src/qt/walletframe.cpp
@@ -166,11 +166,11 @@ void WalletFrame::gotoVerifyMessageTab(QString addr)
         walletView->gotoVerifyMessageTab(addr);
 }
 
-void WalletFrame::encryptWallet(bool status)
+void WalletFrame::encryptWallet()
 {
     WalletView *walletView = currentWalletView();
     if (walletView)
-        walletView->encryptWallet(status);
+        walletView->encryptWallet();
 }
 
 void WalletFrame::backupWallet()

diff --git a/src/qt/walletframe.h b/src/qt/walletframe.h
@@ -79,7 +79,7 @@ public Q_SLOTS:
     void gotoVerifyMessageTab(QString addr = "");
 
     /** Encrypt the wallet */
-    void encryptWallet(bool status);
+    void encryptWallet();
     /** Backup the wallet */
     void backupWallet();
     /** Change encrypted wallet passphrase */

diff --git a/src/qt/walletview.cpp b/src/qt/walletview.cpp
@@ -299,11 +299,11 @@ void WalletView::updateEncryptionStatus()
     Q_EMIT encryptionStatusChanged(walletModel->getEncryptionStatus());
 }
 
-void WalletView::encryptWallet(bool status)
+void WalletView::encryptWallet()
 {
     if(!walletModel)
         return;
-    AskPassphraseDialog dlg(status ? AskPassphraseDialog::Encrypt : AskPassphraseDialog::Decrypt, this);
+    AskPassphraseDialog dlg(AskPassphraseDialog::Encrypt, this);
     dlg.setModel(walletModel);
     dlg.exec();
 

diff --git a/src/qt/walletview.h b/src/qt/walletview.h
@@ -99,7 +99,7 @@ public Q_SLOTS:
     */
     void processNewTransaction(const QModelIndex& parent, int start, int /*end*/);
     /** Encrypt the wallet */
-    void encryptWallet(bool status);
+    void encryptWallet();
     /** Backup the wallet */
     void backupWallet();
     /** Change encrypted wallet passphrase */