Refactor/stackify all the things #5343
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please rebase. |
PastaPastaPasta
force-pushed
the
refactor/stackify-all-the-things
branch
from
de9efb5 to
b458255
Compare
|
This pull request has conflicts, please rebase. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before 227.80s user 48.84s system 97% cpu 4:42.30 total
After 229.49s user 49.36s system 98% cpu 4:43.40 total
Issue being fixed or feature implemented
Move items off the heap and to the stack when possible.
What was done?
Attempted to avoid all uses of std::vector where we know the size of the objects, instead using Span and std::array
How Has This Been Tested?
Reindexed testnet multiple times
Breaking Changes
Should be none
Checklist:
Go over all the following points, and put an
xin all the boxes that apply.