fix: Count all MNs when calculating voting threshold #5584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
knst
reviewed
Sep 26, 2023
Co-authored-by: Konstantin Akimov <[email protected]>
Co-authored-by: Odysseas Gabrielides <[email protected]>
PastaPastaPasta
requested changes
Sep 28, 2023
|
This pull request has conflicts, please rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
This is an alternative to #5583
What was done?
Adjust threshold calculations (instead of ignoring votes form invalid MNs)
How Has This Been Tested?
Breaking Changes
Proposals will need 441 absolute YES votes (vs 374 now). A couple of currently passing proposals won't pass in this version (unless they get more YES votes).
Checklist: