Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: bitcoin/bitcoin#27610: Improve performance of p2p inv to send queues #6086

Merged
merged 1 commit into from
Jun 29, 2024
Merged

backport: bitcoin/bitcoin#27610: Improve performance of p2p inv to send queues #6086

merged 1 commit into from
Jun 29, 2024

Conversation

knst
Copy link
Collaborator

@knst knst commented Jun 29, 2024

Issue being fixed or feature implemented

Couple of performance improvements when draining the inventory-to-send queue:

  • drop txs that have already been evicted from the mempool (or included in a block) immediately, rather than at the end of processing
  • marginally increase outgoing trickle rate during spikes in tx volume

What was done?

Backport bitcoin#27610

How Has This Been Tested?

Run unit/functional tests

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

@knst knst added this to the 21 milestone Jun 29, 2024
@knst knst requested review from UdjinM6 and PastaPastaPasta June 29, 2024 09:25
UdjinM6
UdjinM6 requested changes Jun 29, 2024
View reviewed changes
src/net_processing.cpp Outdated Show resolved Hide resolved
@fanquake @knst
Merge bitcoin#27610: Improve performance of p2p inv to send queues
489b44c 
5b34060 net_processing: Boost inv trickle rate (Anthony Towns)
228e920 txmempool: have CompareDepthAndScore sort missing txs first (Anthony Towns)

Pull request description:

  Couple of performance improvements when draining the inventory-to-send queue:

   * drop txs that have already been evicted from the mempool (or included in a block) immediately, rather than at the end of processing
   * marginally increase outgoing trickle rate during spikes in tx volume

ACKs for top commit:
  willcl-ark:
    ACK 5b34060
  instagibbs:
    ACK bitcoin@5b34060
  darosior:
    utACK 5b34060
  glozow:
    code review ACK 5b34060
  dergoegge:
    utACK 5b34060

Tree-SHA512: 155cd3b5d150ba3417c1cd126f2be734497742e85358a19c9d365f4f97c555ff9e846405bbeada13c3575b3713c3a7eb2f780879a828cbbf032ad9a6e5416b30
@knst knst requested a review from UdjinM6 June 29, 2024 16:51
UdjinM6
UdjinM6 approved these changes Jun 29, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 489b44c

PastaPastaPasta
PastaPastaPasta approved these changes Jun 29, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 489b44c

@PastaPastaPasta PastaPastaPasta merged commit 3e342d7 into dashpay:develop Jun 29, 2024
8 checks passed
@knst knst deleted the bp-27610 branch June 29, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
21
Development

Successfully merging this pull request may close these issues.
4 participants
@knst @UdjinM6 @PastaPastaPasta @fanquake