fix: 6205 follow-up #6206
Merged
fix: 6205 follow-up #6206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm.. or maybe there smth else |
|
For whatever reason GH refuses to even try to start "check merge ff" on dashpay for me (happened a couple of times in earlier PRs too), not sure why it happens or how to fix it. Runs with no issues in my repo https://github.com/UdjinM6/dash/actions/runs/10354130145. |
|
SOooo are we good to merge here? |
|
Let's merge and find out :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
I think I messed up whitespaces so these jobs can't run now, they fail with
[Error] Invalid type for onhttps://github.com/dashpay/dash/actions/runs/10353281487...Weird that they succeeded in #6205 https://github.com/dashpay/dash/actions/runs/10352521500/workflow https://github.com/dashpay/dash/actions/runs/10352521490/workflow 🤷♂️
What was done?
How Has This Been Tested?
Breaking Changes
Checklist: