fix(qt): dashify PSBT: it's Partially Signed BLOCKCHAIN Transaction

[knst]

Issue being fixed or feature implemented

We don't have "partially signed bitcoin transactions", but we have PSBT and it's an established terminology

What was done?

Dashified "blockchain transaction"

How Has This Been Tested?

N/A

Breaking Changes

N/A

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[coderabbitai]

Warning

Rate limit exceeded

@knst has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 36 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 1bdd1c4 and 931fc32.

📒 Files selected for processing (4)

• src/qt/bitcoingui.cpp (1 hunks)
• src/qt/bitcoingui.h (1 hunks)
• src/qt/sendcoinsdialog.cpp (1 hunks)
• src/rpc/rawtransaction.cpp (2 hunks)

Walkthrough

The pull request introduces terminology changes in the Bitcoin Core GUI, specifically updating status tips and tooltips from cryptocurrency-specific references to a more generalized "Blockchain Transaction" terminology. These modifications occur across multiple source files, including src/qt/bitcoingui.cpp, src/qt/sendcoinsdialog.cpp, src/qt/bitcoingui.h, src/qt/walletframe.h, and src/rpc/rawtransaction.cpp.

The changes involve replacing references to "Dash Transaction" and "Bitcoin Transaction" with "Blockchain Transaction" in various user interface elements and documentation comments. This includes updates to the status tips for actions related to loading Partially Signed Bitcoin Transactions (PSBT) and modifications to the documentation for related functions. The changes are purely semantic and do not affect the underlying functionality, logic, or control flow of the application.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[UdjinM6]

pls consider 57821bc

[knst]

pls consider 57821bc

I took changes for RPC, good catch.
Though, I think comments may not need dashification. What's your opinion?

[UdjinM6]

pls consider 57821bc

I took changes for RPC, good catch. Though, I think comments may not need dashification. What's your opinion?

I guess it means less merge conflicts so... works for me :)

I'm not 100% sure if "partially signed blockchain transaction" is a correct term in general though cause only fully signed transactions (or ones that need no signatures to spend coins) are mined to the blockchain but yeah probably a good compromise 🤷‍♂️

[UdjinM6]

utACK 931fc32

[PastaPastaPasta]

utACK 931fc32; though I would probably title this trivial instead of fix as it's just changing strings