Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to edit amount after quick scan #617

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Nov 11, 2023

Issue being fixed or feature implemented

If a QR code with an amount specified is scanned, the app shows the confirmation dialog immediately but it should redirect to the "enter amount" screen and allow to modify the amount.

What was done?

  • Redirect to the "enter amount" screen for QR scanned payment intents.
  • Pre-set the initial amount on the "enter amount" screen.

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf November 11, 2023 12:30
@Syn-McJ Syn-McJ self-assigned this Nov 11, 2023
Copy link
Collaborator

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Syn-McJ Syn-McJ merged commit bd5fd54 into dashpay:develop Nov 13, 2023
1 check passed
@Syn-McJ Syn-McJ deleted the fix/scan-specify-amount branch November 13, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants