Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(voting): cast a vote UI #624

Merged
merged 7 commits into from
Nov 21, 2023
Merged

feat(voting): cast a vote UI #624

merged 7 commits into from
Nov 21, 2023

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Nov 20, 2023

Issue being fixed or feature implemented

  • "Vote to approve" button should allow to add a masternode key and submit a vote for the username request
  • "Quick vote" button should allow to vote for all earliest submitted requests

What was done?

  • UI for adding a MN key
  • UI for displaying IPs of masternodes
  • UI for quick voting

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf November 20, 2023 04:41
@Syn-McJ Syn-McJ self-assigned this Nov 20, 2023
pankcuf
pankcuf approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Syn-McJ Syn-McJ merged commit 3732d3b into dashpay:develop Nov 21, 2023
1 check passed
@Syn-McJ Syn-McJ deleted the feat/voting-cast-vote branch November 21, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankcuf pankcuf pankcuf approved these changes

Assignees

@Syn-McJ Syn-McJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Syn-McJ @pankcuf