Add testing for OSX #859
Merged
Add testing for OSX #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #859 +/- ##
==========================================
+ Coverage 77.44% 77.58% +0.13%
==========================================
Files 71 71
Lines 3600 3600
Branches 634 634
==========================================
+ Hits 2788 2793 +5
+ Misses 685 676 -9
- Partials 127 131 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ayushdg
reviewed
Oct 12, 2022
.github/workflows/test-upstream.yml
Outdated
| - name: Install hive testing dependencies for Linux | ||
| if: matrix.os == 'ubuntu-latest' | ||
| - name: Install hive testing dependencies | ||
| if: matrix.os == 'ubuntu-latest' || matrix.os == 'macos-latest' |
There was a problem hiding this comment.
Given the errors we can either remove docker related testing on Mac-os os experiment with Colima https://github.com/abiosoft/colima which is a part of the images: actions/runner-images#6216
There was a problem hiding this comment.
Toyed around locally with a colima + Docker setup, looks like we end up running into issues after successfully starting up a server that are complex enough that they might necessitate a follow up PR.
For now, will take your advice and disable docker-related tests for macOS.
ayushdg
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With our CI matrix significantly slimmed with the switch to DataFusion, now might be a good time to begin doing dedicated tests on OSX, since we are publishing packages for the platform.